Skip to content

Replace async_track_state_change with async_track_state_change_event #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024

Conversation

mikeage
Copy link
Contributor

@mikeage mikeage commented May 2, 2024

Throws warnings in 2024.5+

See https://developers.home-assistant.io/blog/2024/04/13/deprecate_async_track_state_change/

Note that the component still doesn't work properly under 2024.5; see #326 .

Description

Checklist

  • The PR title is clear, concise and follows conventional commit formatting.
  • Double-check your branch is based on develop and targets develop
  • Issue raised to compliment this PR (if no pre-existing issue exists)
  • Code is commented, particularly in hard-to-understand areas and relevant issues are referenced.
  • Documentation repository updated to reflect new features or changes in behaviour (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.
  • Breaking changes or changes in behaviour are called out and discussed in separate issues.
  • Testing of new changes completed by person who raised the issue.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

License

By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license. Thank you for contributing!

Related Issues

Closes

@robchandhok
Copy link
Contributor

This patch works for me.

@elupus
Copy link
Contributor

elupus commented May 4, 2024

Looks good to me. The threading fixes in that other issue are needed to get it up and running again.

@danobot danobot merged commit 5259d98 into danobot:develop May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants