Check QEMU process status before periodically checking socket files. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the QEMU process exits early due to various reasons, e.g., the missing of kernel binary, providing incorrect qemu commandline arguments, ... and vmtest didn't check the exit status of QEMU and it will wait for 5 seconds to detect the error. This patch teaches vmtest exit earlier when the QEMU process exits unexpectedly.
Owner
|
can you please look into the test failure though? |
Contributor
Author
Thanks for reviewing this! I pushed a new commit to fix the failed test. The root cause is that, after this change, the error message 'qemu: could not open kernel file ...' appears in the 'Caused by' section. We need to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the QEMU process exits early due to various reasons, e.g., the missing of kernel binary, providing incorrect qemu commandline arguments, ... and vmtest didn't check the exit status of QEMU and it will wait for 5 seconds to detect the error.
This patch teaches vmtest exit earlier when the QEMU process exits unexpectedly.