Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add GOOGLE_LOC environment variable for configurable Google API location #4395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

berry-13
Copy link
Collaborator

Summary

Closes #4065

This pull request introduces a new environment variable, GOOGLE_LOC, allowing the Google API location to be configurable. This enhances flexibility in selecting the appropriate regional endpoint when interacting with Google services

Key Changes

  • Added the GOOGLE_LOC environment variable to the configuration
  • Updated relevant service configurations to utilize GOOGLE_LOC for Google API requests (api/app/clients/GoogleClient)

Change Type

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

no testing since I don't have a key for Google and Vertex AI

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Google Env Var - GOOGLE_LOC
1 participant