Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: Delete Archived Chat z-index issue #3643

Conversation

arthurian
Copy link
Contributor

Summary

This PR fixes a UI issue in Settings > General > Archived Chats > Manage where users can't delete an archived chat because the Delete chat? dialog is hidden. The problem is that the z-order was changed at some point, causing the Delete chat? dialog to be stacked behind the Archived chats table (z-index 50 < 999).

This PR updates the z-index on the dialog so that the ordering is as follows:

  1. Settings: z-index: auto
  2. Archived chats: z-index: 999
  3. Delete chat?: z-index: 1000 changed from z-index: 50

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

I tested these changes locally and verified the z-order in the browser using standard devtools. Screenshots included below for reference.

Before the change:

librechat-delete-archived-chat-issue

After the change:

librechat-delete-archived-chat-fix

Test Configuration:

No special configuration required to test, just create a conversation, archive it, and then attempt to delete it.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings

@berry-13
Copy link
Collaborator

wait before merging this, I've probably already fixed this in a bigger branch

@danny-avila
Copy link
Owner

@berry-13 can you specify which branch? Fixes like this should be scoped like this PR

@arthurian
Copy link
Contributor Author

FYI resolved the conflicts introduced by PRs merged before this one, so this branch is mergeable again.

I'm not sure if @berry-13's bigger branch makes the z-index fix obsolete or not. FWIW I did search the issues and open PRs to see if anyone was working on this issue, so I think that's another good reason to more tightly scope PRs moving forward. It helps the rest of us know if an issue is known and being worked on.

@danny-avila danny-avila merged commit 6ad65ff into danny-avila:main Aug 16, 2024
3 checks passed
@danny-avila
Copy link
Owner

thanks, agreed!

@arthurian arthurian deleted the fix/delete-archived-chat-dialog-visibility branch August 16, 2024 18:42
@berry-13
Copy link
Collaborator

@arthurian hey, sorry I missed replying to both you and Danny. Can you let me know which browser you were using for the test? The OGDialog shouldn't have this issue

@arthurian
Copy link
Contributor Author

I was using the Chrome browser for testing if that helps.

kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants