Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 feat: download audio files #3349

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

🔊 feat: download audio files #3349

wants to merge 8 commits into from

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Jul 15, 2024

Summary

introduce an old WIP to download audio files (external only)

Change Type

  • New feature (non-breaking change which adds functionality)

Testing

Tested on Brave and Firefox

Test Configuration:

OpenAI TTS (external)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@berry-13 berry-13 marked this pull request as draft July 15, 2024 19:20
@berry-13 berry-13 marked this pull request as ready for review July 16, 2024 15:11
@plasticlobster
Copy link

Is this functionality planned for a future release? I found this PR, but it looks like it might be an abandoned work in progress. My team has begun work on implementing the same type of feature, and I'd like to figure out if we're spinning our wheels on something that's already in progress.

@danny-avila
Copy link
Owner

Is this functionality planned for a future release? I found this PR, but it looks like it might be an abandoned work in progress. My team has begun work on implementing the same type of feature, and I'd like to figure out if we're spinning our wheels on something that's already in progress.

I wouldn't call this abandoned, mainly not prioritized due to some other exciting initiatives for me and the few helping me maintain.

@plasticlobster If you find this PR useful, I encourage you and your team to use it and, if willing, contribute back to open source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants