Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: Ensure ShareView document title is configured #3336

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

arthurian
Copy link
Contributor

Summary

This PR updates the document title on the shared link view to reflect the conversation title and application title. This will improve accessibility and link sharing/bookmarking.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Tested changes locally to confirm that the shared link view displays the conversation title and application title.

Steps:

  1. Start a new conversation.
  2. In the conversation panel, go to Export > Share
  3. Click Create Link
  4. Visit shared link.
  5. Confirm that the document.title follows the format {conversationTitle} | {appTitle}.
    • The appTitle should match the configured APP_TITLE environment variable. Default is LibreChat if not configured.
    • The conversationTitle should match the displayed heading (h1).

Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@arthurian arthurian force-pushed the fix/share-view-document-title branch from a211b4f to d9344d0 Compare July 23, 2024 19:07
@danny-avila danny-avila merged commit 14eff23 into danny-avila:main Jul 27, 2024
2 checks passed
danny-avila added a commit that referenced this pull request Aug 5, 2024
* 🔧 fix: ensure ShareView document title is configured

* chore: import order

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
danny-avila added a commit that referenced this pull request Aug 17, 2024
* 🔧 fix: ensure ShareView document title is configured

* chore: import order

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
kenshinsamue pushed a commit to intelequia/LibreChat that referenced this pull request Sep 17, 2024
* 🔧 fix: ensure ShareView document title is configured

* chore: import order

---------

Co-authored-by: Danny Avila <danacordially@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants