Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🅰️ feat: dynamic font size #3224

Closed

Conversation

krakenftw
Copy link
Contributor

@krakenftw krakenftw commented Jun 28, 2024

Introduced font-sizing in settings with all translations, Added a CSS var for font-size which changes according to the localstored font-size or default i.e 16px. #3207

Pull Request Template

⚠️ Before Submitting a PR, Please Review:

  • Please ensure that you have thoroughly read and understood the Contributing Docs before submitting your Pull Request.

⚠️ Documentation Updates Notice:

  • Kindly note that documentation updates are managed in this repository: librechat.ai

Summary

Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.

Change Type

Please delete any irrelevant options.

  • New feature (non-breaking change which adds functionality)

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@krakenftw
Copy link
Contributor Author

also i am fairly new to open source, please point out the points of improvement. Here to learn : )

@krakenftw krakenftw changed the title New/feature/dynamic font size feat: dynamic font size #3207 Jun 28, 2024
@krakenftw krakenftw changed the title feat: dynamic font size #3207 feat: dynamic font size Jun 28, 2024
@danny-avila
Copy link
Owner

Hi @krakenftw thanks for your contribution.

At the moment, I can't accept this PR, there are too many linting changes in the stylesheet for me to review. In general, you should prevent any linters that don't result in git differences. If you would like to contribute a CSS linter setup, that would be in a separate PR.

Also, I think it makes sense to make the font size configurable for messages exclusively.

Your addition to the settings tab is still useful, and I can take over from here to revise this if you'd like.

@krakenftw
Copy link
Contributor Author

Hey @danny-avila
The linting changes were mess for me honestly, Prettier was doing the stuff and changed the whole thing.
So basically that font-size would only affect the user/model messages?. I am ready to do this.
Also an idea of which method i should opt to do this would be helpful. Since i am fairly new to open source.

@berry-13 berry-13 changed the title feat: dynamic font size 🅰️ feat: dynamic font size Jul 4, 2024
@danny-avila
Copy link
Owner

Sorry for the long wait, applying my changes here: https://github.com/danny-avila/LibreChat/compare/feat/dynamic-font-size?expand=1

@danny-avila danny-avila closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants