🌏 i18n: Improve clarity of English translation #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiGamji
force-pushed
the
english-i18n-clarity
branch
from
862351e
to
c54b56e
Compare
KiGamji
force-pushed
the
english-i18n-clarity
branch
from
c54b56e
to
6fe855c
Compare
KiGamji
force-pushed
the
english-i18n-clarity
branch
3 times, most recently
from
c551f4f
to
baf45fa
Compare
|
About the 629260f (now — 423d4a8) commit. The thing is — English and Russian (and possibly even more langauges) do not use cases in the same way. Let's take a look on the "Create Prompt" string. In Russian, the word "Prompt" would be written with small letter at the start. Moreover, Russian has lots of grammatical cases, so the word "prompt" would change form depending on its function. With that being said, it's still used as a button/menu title, so it can't be changed that way either. Replacing these strings addresses such linguistic complexities into account, adapting LibreChat to be more natural and grammatically accurate in languages where words change according to their grammatical usage. |
KiGamji
force-pushed
the
english-i18n-clarity
branch
2 times, most recently
from
9ac7acb
to
8f50776
Compare
This commit simplifies the internationalization approach for English language strings by removing the placeholder ones where they are used only once. This makes proper localization possible for Russian language, and possibly others. Also renamed `com_ui_text_prompt` to `com_ui_prompt_text` to match the alphabetical order.
KiGamji
force-pushed
the
english-i18n-clarity
branch
from
8f50776
to
03780fe
Compare
|
@danny-avila any reason of this not getting accepted ? |
if a PR is not closed, it has not been rejected. I work on this as time allows |
danny-avila
approved these changes
Jun 24, 2024
danny-avila
pushed a commit
that referenced
this pull request
Aug 5, 2024
* 🌏 i18n: Improve clarity of English translation * 🔧 fix(useCategories): replace i18n string to `com_ui_select_a_category` * 🔨 refactor: avoid using placeholder strings where possible This commit simplifies the internationalization approach for English language strings by removing the placeholder ones where they are used only once. This makes proper localization possible for Russian language, and possibly others. Also renamed `com_ui_text_prompt` to `com_ui_prompt_text` to match the alphabetical order. * 🎨 style(CreatePromptForm): add missing margin-top to the submit button
kenshinsamue
pushed a commit
to intelequia/LibreChat
that referenced
this pull request
Sep 17, 2024
* 🌏 i18n: Improve clarity of English translation * 🔧 fix(useCategories): replace i18n string to `com_ui_select_a_category` * 🔨 refactor: avoid using placeholder strings where possible This commit simplifies the internationalization approach for English language strings by removing the placeholder ones where they are used only once. This makes proper localization possible for Russian language, and possibly others. Also renamed `com_ui_text_prompt` to `com_ui_prompt_text` to match the alphabetical order. * 🎨 style(CreatePromptForm): add missing margin-top to the submit button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I made some updates to the English localization files to improve the clarity of some strings.
Change Type