Fix for Netflix redesign

[gmertes]

Recent video player redesign broke the extension. The secondary sub list was no longer added to the sub popup.

@makfc fixed it. 🥳

@dannvix suggest to merge and update the Chrome store release asap.

EDIT: This PR is out of date, but I'm keeping it open so the owner might see it. If you're a user of this extension, you can install the updated version from my fork that contains the full fix for the redesign and addition bug fixes.

[Manishearth]

Given that the sub popup is buggy anyway; would it be preferable to eventually add the menu to the extension button too, where stuff is less likely to break?

[gmertes]

Given that the sub popup is buggy anyway; would it be preferable to eventually add the menu to the extension button too, where stuff is less likely to break?

I like that idea, or maybe even have it in both places.

Unfortunately it seems that the repo owner is no longer active. The network graph is also showing some other people working on this in their own forks, but none of those have been merged.

I suggest we move development to another fork. If anyone else wants to work on this, I'm accepting PR's into my fork and am planning to keep it maintained, as well as rerelease it on the chrome store (though I'm not that great with JS so collaborators are welcome).

[gmertes]

@dannvix if you're still around: I'm willing to help maintain the project (or take over if necessary). It'd be nice if we could update the original Chrome store extension as that one already has a ton of users. I was going to create my own release on the store for those people using it there, but that will also lead to fragmentation which I'd like to avoid if possible.

Are you comfortable giving me write access here and publishing rights on the Chrome ext? Hit me up on gmertes at outlook.be

A fix for the redesign (and one other bug) is now also available in my fork.

[laureograph]

Hi! I was so pleased to find that someone has provided a fix for the new netflix update -- thank you so much to all of you for developing this. I was just wondering whether it would be possible for one of you to post somewhere instructions for those of us not familiar with coding etc. how to manually update our own Chrome extensions/versions of this, with the fixes you have provided above? I would appreciate this so much, and I'm sure others would too, while we wait for the Chrome store version to be updated.

[MARWAN-FAGEEH]

This is my first post on this site,
I'm not a programmer or developer and I don't know anything about it,
In the past my foreign wife and I were watching
Netflix separately because of the translation,
But after discovering this wonderful addition, the situation changed.
After updating the Netflix player, the add-on stopped working,
I looked for others, and after trying a lot of browser extensions.
Which was stopped working because of the player update.
I found - (Language Reactor) - and it was working fine.
But I was not satisfied with the font style and size, because I got used to the -(NflxMultiSubs)- style.
I hope the owners of the add-on update it, thank you.
( Google Translate)

[MARWAN-FAGEEH]

@dannvix if you're still around: I'm willing to help maintain the project (or take over if necessary). It'd be nice if we could update the original Chrome store extension as that one already has a ton of users. I was going to create my own release on the store for those people using it there, but that will also lead to fragmentation which I'd like to avoid if possible.

Are you comfortable giving me write access here and publishing rights on the Chrome ext? Hit me up on gmertes at outlook.be

A fix for the redesign (and one other bug) is now also available in my fork.

This is his Twitter account
https://twitter.com/dannvix

[gmertes]

@MARWAN-FAGEEH You can install the fixed version from my fork. There are instructions on how to install it here.

I'll see if I can get in touch with the owner via twitter.

[MARWAN-FAGEEH]

@MARWAN-FAGEEH You can install the fixed version from my fork. There are instructions on how to install it here.

I'll see if I can get in touch with the owner via twitter.

It works thank you very much

[eecheng87]

@gmertes, thanks for your patch.
Following your guide, my secondary option pop out.
However, there is no language option I can choose. Is that expected?

[gmertes]

@gmertes, thanks for your patch. Following your guide, my secondary option pop out. However, there is no language option I can choose. Is that expected?

Hi, have you tried refreshing the player after starting playback? Also be sure to remove the original extension if you have it installed from the chrome store, and try restarting the browser.

If the problem still persists please open an Issue over at my fork, thanks.

[dannvix]

@gmertes Thanks for the fix and suggestions. You'll see a new version published on Chrome Web Store soon (better late than never).

I'm more than happy to know you offered to contribute the maintenance. Sadly it didn't go right last time I tried granting the ownership to a developer who claimed he'd actively keep this extension updated (see commit 2d5e683, the history is still out there).

As this repository and extension is all licensed under MIT, feel free to publish your forked version on the marketplace. Sorry for letting you down but I'd see this repository goes inactive (and not usable maybe) rather than see it's used for some other purpose.

[gmertes]

Ok. And yes I already released my own version on the Chrome store to get a working version out there. There have been quite a lot of breaking changes from ntflx lately (more since this PR), those have all been fixed in my fork. I also fixed a bunch of bugs that the original had. You're free to pull those into your repository. I will keep my own development over in my fork because then I can quickly publish new versions to the store myself if something breaks again in the future.

I just think it's a shame to fragment versions like this, because your original was used by a lot of people.