Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to set custom AWS S3 settings for coverband #98

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

a0s
Copy link

@a0s a0s commented Feb 27, 2018

Add support for separate AWS S3 settings of region/bucket/key/secret for coverband in case when we don't want to use default AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY.

Old behaviour, reading from AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY:

Coverband.configure do |config|
  ...
  config.s3_bucket = 'bucket_name'
  ...
end

New behaviour, set all settings for coverband only:

Coverband.configure do |config|
  ...
  config.s3_bucket = ENV['COVERBAND_AWS_BUCKET']
  config.s3_region = ENV['COVERBAND_AWS_REGION']
  config.s3_access_key_id = ENV['COVERBAND_AWS_KEY']
  config.s3_secret_access_key = ENV['COVERBAND_AWS_SECRET']
  ...
end

@danmayer
Copy link
Owner

I will address this in a quick follow up after getting 2.0 released...

PR for Coverband 2.0! Alpha release running on prod for last 2 months. Let me know if there is any last minute feedback, if not I will release later tonight ;) Also, sharing thoughts Future 3.0 roadmap.

#107

@a0s
Copy link
Author

a0s commented Jul 22, 2018

For now, we are using 1.5.4 with this PR. So it would be great to include this into 2.0 ...

@danmayer danmayer merged commit dfe76f5 into danmayer:master Jul 24, 2018
@danmayer
Copy link
Owner

OK, this is merged into the 2.0 line, on the master branch. I am going to handle some of the other PRs and get a 2.x.x out in a few days, which will include this work. Thanks @a0s

@danmayer
Copy link
Owner

danmayer commented Aug 8, 2018

this is in the 2.0.1 release https://github.com/danmayer/coverband/blob/master/changes.md#201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants