fixed #498 - avoid potential leak in simplecpp::Macro::parseDefine()

[firewave]

No description provided.

[firewave]

This fixes the issue but I am not convinced this is the full fix. It seems there is a parseDefine() call which should not be happening since a macro is being re-defined.

[firewave]

This fixes the issue but I am not convinced this is the full fix. It seems there is a parseDefine() call which should not be happening since a macro is being re-defined.

The GNU compilers both only show a warning, so this fix should be fine.

a.cpp:2:9: warning: 'e' macro redefined [-Wmacro-redefined]
    2 | #define e
      |         ^
a.cpp:1:9: note: previous definition is here
    1 | #define e(...)__VA_OPT__()
      |         ^

a.cpp:2:9: warning: ‘e’ redefined
    2 | #define e
      |         ^
a.cpp:1:9: note: this is the location of the previous definition
    1 | #define e(...)__VA_OPT__()
      |         ^

[danmar]

I assume this has to be executed by some valgrind or sanitizer to detect the issue? i.e. if I just compile and run then this test does not ensure there is no leak?
It feels a bit misplaced somehow but maybe writing a separate test for it is overkill.. but well a comment would be nice?

[firewave]

Yes, obviously you need to run a leak checker.

I assumed the test name leak was enough. I can add a comment.

[firewave]

I added some comments.