Taking care of operation overloading functions#958
Closed
Hinterwaeldlers wants to merge 1 commit intodanmar:masterfrom
Closed
Taking care of operation overloading functions#958Hinterwaeldlers wants to merge 1 commit intodanmar:masterfrom
Hinterwaeldlers wants to merge 1 commit intodanmar:masterfrom
Conversation
Owner
|
Please remove the |
Contributor
Author
|
ups thx. will remove it |
Hinterwaeldlers
force-pushed
the
overloadOperator
branch
from
4517a4b to
0c6fdf0
Compare
Collaborator
|
Compatibility with VS10 was violated, see https://ci.appveyor.com/project/danmar/cppcheck/build/1.73.4338/job/rp3u52i8bkwof3ra |
danmar
reviewed
Oct 19, 2017
| // Deallocation variants; space is delete within the simplification | ||
| "delete", "delete[]" | ||
| }; | ||
| for (auto const & curOp : knownOperators) { |
Owner
There was a problem hiding this comment.
please don't use a ranged for loop. That is C++11. It seems clumpsy to check for every known operator. If opName is any operator (!std::isalnum(opName[0] && opName[0] != '_')) then I think this function could return true.
Owner
|
I close this pull request because there are unhandled review comments. I think only minor tweaks are needed. Feel free to reopen if you fix the review comments. |
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 7, 2026
Using while(!feof(fp)) is a common C bug: feof() only returns true after a read has already failed, causing the loop body to execute once more after the last successful read. Read errors also go undetected since feof() does not distinguish them from EOF. Signed-off-by: Francois Berder <fberder@outlook.fr>
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 7, 2026
feof() only returns true after a read has already failed, causing the loop body to execute once more after the last successful read. Read errors also go undetected since feof() does not distinguish them from EOF. Signed-off-by: Francois Berder <fberder@outlook.fr>
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 7, 2026
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 8, 2026
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 12, 2026
…ile loop condition
francois-berder
added a commit
to francois-berder/cppcheck
that referenced
this pull request
Apr 12, 2026
…as a while loop condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an operation is overloaded, the related function was incorrectly marked as unused. This fix the related false positive and append related tests