Skip to content

Fix #1473: warn when fclose() is used as a while loop condition #8444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francois-berder wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Fix #1473: warn when fclose() is used as a while loop condition #8444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions lib/checkio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,19 @@ void CheckIO::checkFileUsage()
} else if (tok->str() == "fclose") {
fileTok = tok->tokAt(2);
operation = Filepointer::Operation::CLOSE;

// #1473 Check if fclose is in a while loop condition
const Token* tmp = tok->astParent();
const Token* loopTok = nullptr;
while (tmp) {
if (Token::simpleMatch(tmp->previous(), "while (")) {
loopTok = tmp->previous();
break;
}
tmp = tmp->astParent();
}
if (loopTok)
useClosedFileError(tok);
} else if (whitelist.find(tok->str()) != whitelist.end()) {
fileTok = tok->tokAt(2);
if ((tok->str() == "ungetc" || tok->str() == "ungetwc") && fileTok)
Expand Down
2 changes: 1 addition & 1 deletion test/testio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ class TestIO : public TestFixture {
" FILE *a = fopen(\"aa\", \"r\");\n"
" while (fclose(a)) {}\n"
"}");
TODO_ASSERT_EQUALS("[test.cpp:3:5]: (error) Used file that is not opened. [useClosedFile]\n", "", errout_str());
ASSERT_EQUALS("[test.cpp:3:12]: (error) Used file that is not opened. [useClosedFile]\n", errout_str());

// #6823
check("void foo() {\n"
Expand Down
Loading