refs #3452 - assert on unprintable characters in error messages#8270
Draft
firewave wants to merge 1 commit intodanmar:mainfrom
Draft
refs #3452 - assert on unprintable characters in error messages#8270firewave wants to merge 1 commit intodanmar:mainfrom
firewave wants to merge 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
These need to be escaped otherwise they will be printed literally. |
Collaborator
Author
|
I think asserting should be sufficient for now since unprintable characters should never appear in the actual (mainly hard-coded) error messages. The tests containing such characters do not essentially reflect real-life code and we should rely on daca feedback instead. The part of the of the message which contains actual code needs to be escaped. But I will address this is a separate PR. |
firewave
added
the
merge-after-next-release
|
firewave
removed
the
merge-after-next-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.