refs #14226 - ImportProject: removed need for test class friend declaration / cleanups #8182
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration / cleanups
|
firewave
commented
Feb 3, 2026
Comment on lines
-35
to
+42
| class TestImporter : public ImportProject { | ||
| class TestImporter final : public ImportProject { | ||
| public: | ||
| using ImportProject::importCompileCommands; | ||
| using ImportProject::importCppcheckGuiProject; | ||
| using ImportProject::importVcxproj; | ||
| using ImportProject::SharedItemsProject; | ||
| using ImportProject::collectArgs; | ||
| using ImportProject::fsSetDefines; |
Collaborator
Author
There was a problem hiding this comment.
This looks better than the friend approach I used in all the other cases. I will look into adjusting the others. I will not do it to the existing open PRs but do it in a batch later on since I still have others sitting locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.