refs #10736 - cli/main.cpp: removed conditional (NDEBUG) exception handling#8122
Merged
firewave merged 1 commit intodanmar:mainfrom Jan 21, 2026
Merged
refs #10736 - cli/main.cpp: removed conditional (NDEBUG) exception handling#8122firewave merged 1 commit intodanmar:mainfrom
NDEBUG) exception handling#8122firewave merged 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
It was only enabled in Windows build. And did not make much sense since the called function does not throw. This also makes it easier to detect uncaught exceptions in static analysis. |
firewave
changed the title
NDEBUG) exception handlingNDEBUG) exception handling
firewave
changed the title
NDEBUG) exception handlingNDEBUG) exception handling
|
danmar
reviewed
Jan 14, 2026
danmar
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.