Fix #14433 (Import project: refactor code to read compile_commands.json)#8030
Merged
danmar merged 9 commits intodanmar:mainfrom Jan 26, 2026
Merged
Fix #14433 (Import project: refactor code to read compile_commands.json)#8030danmar merged 9 commits intodanmar:mainfrom
danmar merged 9 commits intodanmar:mainfrom
Conversation
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
3792859 to
7941aae
Compare
Collaborator
|
The clang-tidy warning seems to be a false positive, I have reported it here: llvm/llvm-project#172018 |
danmar
reviewed
Dec 14, 2025
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I have not checked it in detail yet but this is better approach in my opinion. 👍
I feel we shouldn't merge this before the release though it could introduce some bug.
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
3 times, most recently
from
5fbb9e0 to
b6c9031
Compare
chrchr-github
added
the
merge-after-next-release
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
0e066dd to
a9fd6d4
Compare
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
8e36982 to
20ac362
Compare
danmar
reviewed
Jan 2, 2026
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
7c73ad4 to
fb2e7b3
Compare
danmar
reviewed
Jan 6, 2026
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
from
fb2e7b3 to
a203ada
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
4fb1d36 to
63dae98
Compare
danmar
reviewed
Jan 12, 2026
.github/workflows/selfcheck.yml
Outdated
| - name: Self check (unusedFunction / no test / no gui) | ||
| run: | | ||
| supprs="--suppress=unusedFunction:lib/errorlogger.h:196 --suppress=unusedFunction:lib/importproject.cpp:1516 --suppress=unusedFunction:lib/importproject.cpp:1540" | ||
| supprs="--suppress=unusedFunction:lib/errorlogger.h:196 --suppress=unusedFunction:lib/importproject.cpp:1515 --suppress=unusedFunction:lib/importproject.cpp:1539" |
Owner
There was a problem hiding this comment.
@firewave it feels like inline suppressions should be used instead. why don't we? my spontanous guess is that different selfchecks generate different warnings?
Owner
There was a problem hiding this comment.
@firewave or how about adding maybe_unused attributes to the functions?
danmar
reviewed
Jan 20, 2026
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
some more small nits. overall this PR makes the code much cleaner imho and I envision it will be more robust thanks to that.
danmar
reviewed
Jan 20, 2026
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
46445d7 to
48dd74c
Compare
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
2 times, most recently
from
d3ce262 to
f7ac10e
Compare
danmar
reviewed
Jan 21, 2026
ludviggunne
force-pushed
the
cdb-parse-rewrite
branch
from
f7ac10e to
33c4119
Compare
|
danmar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been multiple issues with the import lately, and (my) fixes have been a bit hacky. With this change,
commandis first split similarily to how the shell would, and is then handled like theargumentsfield. For extracting compiler options, the argument list is handled like the compiler would readargv. I believe this will be easier to maintain in the future.