fixed #13388 - store active checkers in build dir#7852
Merged
firewave merged 1 commit intodanmar:mainfrom Sep 29, 2025
Merged
Conversation
firewave
force-pushed
the
builddir-checkers
branch
from
d2d6623 to
4907ae7
Compare
Collaborator
Author
|
No test has been added since it is tested via the |
firewave
force-pushed
the
builddir-checkers
branch
from
4907ae7 to
711d3d5
Compare
firewave
commented
Sep 25, 2025
Comment on lines
+326
to
+330
| // cppcheck-suppress accessMoved - FP | ||
| while (std::getline(fout, line)) | ||
| { | ||
| // cppcheck-suppress accessMoved - FP | ||
| activeCheckers.emplace(std::move(line)); |
Collaborator
Author
There was a problem hiding this comment.
This code was copied and the false positives are already being tracked in https://trac.cppcheck.net/ticket/11300.
danmar
reviewed
Sep 27, 2025
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
👍 I am happy with this if the ifstream object is renamed to fin.
cli/cppcheckexecutor.cpp
Outdated
| if (mCheckersFile.empty()) | ||
| return; | ||
|
|
||
| std::ifstream fout(mCheckersFile); |
firewave
force-pushed
the
builddir-checkers
branch
from
711d3d5 to
6e78f7b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.