Fix #13928 (existing system include is not found)#7678
Merged
danmar merged 3 commits intodanmar:mainfrom Jul 17, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an end-to-end test to ensure <string> is correctly detected as a missing system include and then resolved when its directory is supplied, fixing issue #13928.
- Introduced
test_preprocess_system_includeinother_test.py - Imported
globto locate the system<string>header - Verified
cppcheckemits a missing‐include warning without-Iand suppresses it when the include path is provided
Comments suppressed due to low confidence (3)
test/cli/other_test.py:3333
- [nitpick] Hard-coding
/usr/include/c++/*/stringmay not work on all platforms or compiler installations. Consider detecting system include paths viasysconfigor a test fixture, or skip more robustly on unsupported environments.
g = glob.glob('/usr/include/c++/*/string')
test/cli/other_test.py:3333
- [nitpick] The variable name
gis ambiguous. Rename it to something more descriptive likematchesorheader_paths.
g = glob.glob('/usr/include/c++/*/string')
test/cli/other_test.py:3345
- [nitpick] The name
g0is not descriptive. Consider renaming it toheader_pathorstring_headerfor clarity.
g0 = str(g[0])
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.