ValueFlow: avoid various unnecessary copies #7583
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mostly taken from #6756 and discovered by reviewing the code. Still needs to be profiled. |
|
Not much in terms of performance which is not surprising since these were found by review and not by profiling. |
danmar
reviewed
Jun 12, 2025
| { | ||
| if (!precedes(start, end)) | ||
| throw InternalError(var->nameToken(), "valueFlowForwardConst: start token does not precede the end token."); | ||
| for (Token* tok = start; tok != end; tok = tok->next()) { | ||
| if (tok->varId() == var->declarationId()) { | ||
| for (const ValueFlow::Value& value : values) | ||
| setTokenValue(tok, value, settings); | ||
| for (ValueFlow::Value& value : values) |
There was a problem hiding this comment.
if more then one token has matching varid and this inner loop is executed twice then you will move values that are already moved.
There was a problem hiding this comment.
Good catch. I was relying on the selfcheck/clang-tidy to catch these things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.