Display inline suppressions in XML output #7581
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludviggunne
force-pushed
the
xml-inline-suppressions
branch
from
556706b to
0f33461
Compare
danmar
reviewed
Jun 9, 2025
| return; | ||
|
|
||
| auto &out = mErrorOutput ? *mErrorOutput : std::cerr; | ||
| out << " <inline-suppressions>" << std::endl; |
There was a problem hiding this comment.
it feels like it might be possible to reuse the SuppressionList::dump.
both inline and non-inline suppressions should be stored in the xml file and it's not required that they are stored separately.
| args = [ | ||
| '-q', | ||
| '--inline-suppr', |
There was a problem hiding this comment.
I don't remember if some -j2 and -j1 is injected somehow in the CI. but it would make sense to test that this works with multiple jobs also.
| '--inline-suppr', | ||
| '--xml-version=3', | ||
| f'{__proj_inline_suppres_path}template.cpp' |
There was a problem hiding this comment.
I suggest that os.path.join is used instead of direct string concatenation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.