-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed #11342 - cache Library::getFunctionName()
calls in Token
#7573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Still that shouldn't produce different results on subsequent calls on the same token. Since the library is immutable it seems like this is caused by some tokenizing/simplification. |
The problem is that the From
|
b1f1df1
to
2cee634
Compare
if (!mImpl->mFuncName) | ||
mImpl->mFuncName = new std::string(library.getFunctionName(this)); | ||
const std::string fname = library.getFunctionName(this); | ||
std::cout << this << " astParent: " << astParent() << " previous: " << previous() << " " << stringify(stringifyOptions::forDebug()) << " " << fname << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is debug code that will be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still WIP - I forgot to mark it a draft.
I assume there is speedup but do you see it also? |
Since it is still a draft (and not working as expected) I did not provide performance data yet. It is about 2-4% of the total Ir - that is also mentioned in the ticket. |
No description provided.