fixed #13641 - improved ignoring directories and overall testing of ignore#7222
Merged
firewave merged 11 commits intodanmar:mainfrom Mar 15, 2025
Merged
fixed #13641 - improved ignoring directories and overall testing of ignore#7222firewave merged 11 commits intodanmar:mainfrom
firewave merged 11 commits intodanmar:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
ignore
branch
2 times, most recently
from
d8f70f6 to
aed42c8
Compare
firewave
force-pushed
the
ignore
branch
4 times, most recently
from
2201168 to
f975fe6
Compare
firewave
changed the title
firewave
changed the title
firewave
force-pushed
the
ignore
branch
2 times, most recently
from
8e7ea9f to
2aaea8b
Compare
firewave
force-pushed
the
ignore
branch
2 times, most recently
from
52966c8 to
283095d
Compare
firewave
changed the title
danmar
reviewed
Feb 24, 2025
|
|
||
| bool isdir = false; | ||
| if (!Path::exists(path, &isdir) && mSettings.debugignore) | ||
| std::cout << "path to ignore does not exist: " << path << std::endl; |
Owner
There was a problem hiding this comment.
is there a better way to output this. A plugin might expect "cppcheck: error: ..." if we are fortunate but it will not expect this output :-(
if it at least starts with "cppcheck: " that is better imho.
Collaborator
Author
There was a problem hiding this comment.
None of any of the debug messages are currently prefixed. That also needs to go through a dedicated logger/stream but is currently not the case and will probably be some work. That is something to maybe look into after https://trac.cppcheck.net/ticket/13200 is fixed.
Collaborator
Author
|
No further feedback for almost three weeks - merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.