-
Notifications
You must be signed in to change notification settings - Fork 1.5k
generate *.vcxproj
file lists with dmake
#4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The |
…dio by actually exporting symbols
With the files normalized we no longer need the hack in the CI and this PR will now properly show all the changes without adjusting the viewer options. |
I think your approach is reasonable 👍 To read the existing vcxproj file and just replace the file lists. |
Anything left to do to get this merged? |
cli.vcxproj
andtestrunner.vcxproj
are changed completely since the newlines were wrong (CR instead of CRLF). We need a proper.gitattributes
file which enforces those. To view those changes you need to enable theHide whitespace
option in the diff viewer (accessible via the "gear" icon).The added
Label
attribute is allowed - it is simply not used by Visual Studio in those files. It does allow use to define marker and the file lists in question so we can rewrite them.I have no added writing of the
*.vcxproj.filters
yet but that is simply for grouping in the IDE and has no effect on the builds. Will add that in a later PR.