[2.7.x] Set tinyxml2_LIBRARIES after find_package() #3932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is based on #3918 for the 2.7.x branch. |
If tinyxml2 is found by find_package(), then tinyxml2_LIBRARIES is empty. Set tinyxml2_LIBRARIES to "tinyxml2::tinyxml2" in this case. - Fixes "undefined reference to `tinyxml2::" - printInfo.cmake: Fix indentation of tinyxml2_LIBRARIES
c72578
force-pushed
the
2022-03-23_tinyxml2_update_for_2.7.x_branch
branch
from
6049995 to
4ae07fe
Compare
c72578
changed the title
Owner
|
I am fixing the CI error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If tinyxml2 is found by
find_package(), thentinyxml2_LIBRARIESis empty. Set
tinyxml2_LIBRARIESto"tinyxml2::tinyxml2"in this case.undefined reference totinyxml2::`"printInfo.cmake: Fix indentation oftinyxml2_LIBRARIES