Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some preparations for Qt6 support #3777

Merged
merged 3 commits into from
Feb 7, 2022
Merged

some preparations for Qt6 support #3777

merged 3 commits into from
Feb 7, 2022

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jan 30, 2022 •
edited
Loading

The QString casts are necessary since in Qt6 they are QStringView and those cannot be compared with string literals.

@firewave firewave marked this pull request as draft January 30, 2022 15:18
@firewave firewave marked this pull request as ready for review January 30, 2022 16:14
danmar
danmar approved these changes Feb 1, 2022
View reviewed changes
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to merge this after the release

@danmar danmar added the merge-after-next-release Wait with merging this PR until after the next Release label Feb 1, 2022
@firewave firewave merged commit d528555 into danmar:main Feb 7, 2022
@firewave firewave deleted the qt6 branch February 7, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmar danmar danmar approved these changes

Assignees
No one assigned
Labels
merge-after-next-release Wait with merging this PR until after the next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @danmar