forked from uber/cadence
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve archival related code (uber#2268)
- Loading branch information
Showing
45 changed files
with
803 additions
and
523 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| // Copyright (c) 2019 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package archiver | ||
|
|
||
| import ( | ||
| "errors" | ||
| "net/url" | ||
| ) | ||
|
|
||
| type ( | ||
| // URI identifies the archival resource to which records are written to and read from. | ||
| URI interface { | ||
| Scheme() string | ||
| Path() string | ||
| Hostname() string | ||
| Port() string | ||
| Username() string | ||
| Password() string | ||
| String() string | ||
| } | ||
|
|
||
| uri struct { | ||
| url *url.URL | ||
| } | ||
| ) | ||
|
|
||
| // NewURI constructs a new archiver URI from string. | ||
| func NewURI(s string) (URI, error) { | ||
| url, err := url.ParseRequestURI(s) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if url.Opaque != "" { | ||
| return nil, errors.New("URI should begin with scheme://") | ||
| } | ||
| return &uri{url: url}, nil | ||
| } | ||
|
|
||
| func (u *uri) Scheme() string { | ||
| return u.url.Scheme | ||
| } | ||
|
|
||
| func (u *uri) Path() string { | ||
| return u.url.Path | ||
| } | ||
|
|
||
| func (u *uri) Hostname() string { | ||
| return u.url.Hostname() | ||
| } | ||
|
|
||
| func (u *uri) Port() string { | ||
| return u.url.Port() | ||
| } | ||
|
|
||
| func (u *uri) Username() string { | ||
| if u.url.User == nil { | ||
| return "" | ||
| } | ||
| return u.url.User.Username() | ||
| } | ||
|
|
||
| func (u *uri) Password() string { | ||
| if u.url.User == nil { | ||
| return "" | ||
| } | ||
| password, exist := u.url.User.Password() | ||
| if !exist { | ||
| return "" | ||
| } | ||
| return password | ||
| } | ||
|
|
||
| func (u *uri) String() string { | ||
| return u.url.String() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| // Copyright (c) 2019 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package archiver | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| type ( | ||
| URISuite struct { | ||
| *require.Assertions | ||
| suite.Suite | ||
| } | ||
| ) | ||
|
|
||
| func TestURISuite(t *testing.T) { | ||
| suite.Run(t, new(URISuite)) | ||
| } | ||
|
|
||
| func (s *URISuite) SetupTest() { | ||
| s.Assertions = require.New(s.T()) | ||
| } | ||
|
|
||
| func (s *URISuite) TestURI() { | ||
| testCases := []struct { | ||
| URIString string | ||
| valid bool | ||
| scheme string | ||
| path string | ||
| hostname string | ||
| port string | ||
| username string | ||
| password string | ||
| }{ | ||
| { | ||
| URIString: "", | ||
| valid: false, | ||
| }, | ||
| { | ||
| URIString: "some random string", | ||
| valid: false, | ||
| }, | ||
| { | ||
| URIString: "mailto:a@b.com", | ||
| valid: false, | ||
| }, | ||
| { | ||
| URIString: "test://", | ||
| valid: true, | ||
| scheme: "test", | ||
| }, | ||
| { | ||
| URIString: "http://example.com/path", | ||
| valid: true, | ||
| scheme: "http", | ||
| hostname: "example.com", | ||
| path: "/path", | ||
| }, | ||
| { | ||
| URIString: "http://example.com/path with space", | ||
| valid: true, | ||
| scheme: "http", | ||
| hostname: "example.com", | ||
| path: "/path with space", | ||
| }, | ||
| { | ||
| URIString: "https://localhost:8080", | ||
| valid: true, | ||
| scheme: "https", | ||
| hostname: "localhost", | ||
| port: "8080", | ||
| }, | ||
| { | ||
| URIString: "file:///absolute/path/to/dir", | ||
| valid: true, | ||
| scheme: "file", | ||
| path: "/absolute/path/to/dir", | ||
| }, | ||
| { | ||
| URIString: "test://person:password@host/path", | ||
| valid: true, | ||
| scheme: "test", | ||
| hostname: "host", | ||
| path: "/path", | ||
| username: "person", | ||
| password: "password", | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testCases { | ||
| URI, err := NewURI(tc.URIString) | ||
| if !tc.valid { | ||
| s.Error(err) | ||
| continue | ||
| } | ||
|
|
||
| s.NoError(err) | ||
| s.Equal(tc.scheme, URI.Scheme()) | ||
| s.Equal(tc.path, URI.Path()) | ||
| s.Equal(tc.hostname, URI.Hostname()) | ||
| s.Equal(tc.port, URI.Port()) | ||
| s.Equal(tc.username, URI.Username()) | ||
| s.Equal(tc.password, URI.Password()) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.