Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gcc warnings broke Encode with perl 5.8.9 on Win32 #113

Closed
pali opened this issue Jun 19, 2017 · 3 comments
Closed

New gcc warnings broke Encode with perl 5.8.9 on Win32 #113

pali opened this issue Jun 19, 2017 · 3 comments

Comments

@pali
Copy link
Contributor

pali commented Jun 19, 2017

In commit d92071d @rurban added new gcc warning flags -Werror=declaration-after-statement and -Wpointer-sign which caused compile errors with perl 5.8.9 on Win32. Problem is reported in CPAN Testers Matrix.

See http://www.cpantesters.org/cpan/report/ebf45fc3-6d42-1014-9ffc-b1671f639c1c

gcc -c -IEncode -s -O2 -DWIN32 -DHAVE_DES_FCRYPT -DUSE_SITECUSTOMIZE -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -fno-strict-aliasing -DPERL_MSVCRT_READFIX -Werror=declaration-after-statement -Wpointer-sign -s -O2 -DVERSION="2.90" -DXS_VERSION="2.90" "-IC:\strawberry\perl\lib\CORE" Encode.c
cc1.exe: error: unrecognized command line option "-Werror=declaration-after-statement"
cc1.exe: error: unrecognized command line option "-Wpointer-sign"
dmake.EXE: Error code 129, while making 'Encode.o'

@rurban Can you look at that your commit?

@rurban
Copy link
Contributor

rurban commented Jun 19, 2017

Sure, happy to fix it for older gcc's

rurban added a commit to rurban/p5-encode that referenced this issue Jun 19, 2017
rurban added a commit to rurban/p5-encode that referenced this issue Jun 19, 2017
@mariopaumann
Copy link

mariopaumann commented Sep 4, 2017

@rurban

-Werror=declaration-after-statement is not available on 4.1.2 gcc too.

[perl@apacrslnxe1 ~]$ gcc -Werror=declaration-after-statement /tmp/a.c
cc1: error: unrecognized command line option "-Werror=declaration-after-statement"
[perl@apacrslnxe1 ~]$ gcc -Wpointer-sign /tmp/a.c
[perl@apacrslnxe1 ~]$ gcc --version
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)

@rurban
Copy link
Contributor

rurban commented Sep 5, 2017

Thanks, I only checked the docs for those old GCC's.
See the next PR #121

rurban added a commit to rurban/p5-encode that referenced this issue Sep 5, 2017
I only checked the docs for the warning on old gcc's, but
apparently they deviate on -Werror=declaration-after-statement support.

Fixes dankogai#113
rurban added a commit to rurban/p5-encode that referenced this issue May 10, 2019
rurban added a commit to rurban/p5-encode that referenced this issue May 10, 2019
I only checked the docs for the warning on old gcc's, but
apparently they deviate on -Werror=declaration-after-statement support.

Fixes dankogai#113
khwilliamson pushed a commit to khwilliamson/p5-encode that referenced this issue May 2, 2020
khwilliamson pushed a commit to khwilliamson/p5-encode that referenced this issue May 2, 2020
I only checked the docs for the warning on old gcc's, but
apparently they deviate on -Werror=declaration-after-statement support.

Fixes dankogai#113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants