Skip to content

Conversation

@mjkpolo
Copy link

@mjkpolo mjkpolo commented Aug 16, 2025

This addresses the FIXME here:

// FIXME if parameters match current setup, do nothing, and return bmap

I noticed some mild distortion when drawing a large bitmap with NCBLIT_2x1. This fixes my issue. It might not be very elegant so I'm open to any feedback!

@dankamongmen
Copy link
Owner

Neat! Let me take a look. If possible, I'd love to see examples of the problem you were seeing beforehand, and the results after your change, but that's not necessary.

@dankamongmen
Copy link
Owner

this looks simple enough, and correct. i'd like you to make the whitespace conform with the rest of the code, please.

i'm a bit worried about your claim that you were seeing distortion before, though. i'd like to see what kind of distortion you were running into. i'd love the relevant code/data, and ideally screenshots before and after. this certainly seems like something we can merge, though. i'm a bit surprised i didn't do it before, but [shrug] i'm glad you did!

@dankamongmen dankamongmen self-assigned this Aug 17, 2025
@mjkpolo
Copy link
Author

mjkpolo commented Aug 17, 2025

For sure! I think by tonight I can send some example code and screenshots of the problem. Thanks so much! This is an awesome tool

@mjkpolo
Copy link
Author

mjkpolo commented Aug 17, 2025

If you need a more minimal example let me know, but here are some screenshots from my repo with and without the change where green circles are how it's supposed to look, and red circles are what it looks like without the patch

with_patch without_patch

The errors are from drawing this png so you can see the same distortion comparing to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants