Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debwarrior not triggering blitstacking #1322

Closed
dankamongmen opened this issue Feb 2, 2021 · 3 comments
Closed

debwarrior not triggering blitstacking #1322

dankamongmen opened this issue Feb 2, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dankamongmen
Copy link
Owner

I'm convinced that our fix to #1068 is good, as are our unit tests. debwarrior, however, is still showing the old behavior. It showed the desired behavior before introducing the crender->s.blittedquads condition to paint(), but we need that, and it's correct. No, the real problem (as verified by debugging) is that somehow the overworld map is being blitted (using NCBLIT_2x2) without quadblit bits. Celes does get the expected bits, and propagates them down, but then we hit the overworld, have a valid non-0 crender->s.blittedquads, but no cell_blittedquads(vis).

This isn't Notcurses proper, but get it resolved as part of the blitter stacking saga. There's definitely a bug here, though it might just be out in debwarrior.

@dankamongmen dankamongmen added the bug Something isn't working label Feb 2, 2021
@dankamongmen dankamongmen added this to the 2.2.0 milestone Feb 2, 2021
@dankamongmen dankamongmen self-assigned this Feb 2, 2021
@dankamongmen
Copy link
Owner Author

Nope, it was a bug of ours, one I figured out immediately after cutting 2.1.8 (argh). Fix is incoming.

@dankamongmen
Copy link
Owner Author

Yep, debwarrior now appears to work perfectly. w00t! =]

@dankamongmen
Copy link
Owner Author

Indeed, she finally looks right =]

2021-02-03-130305_802x1417_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant