Add support for title to links in dropdowns | Fixes liferay#832

danilodamata · Apr 23, 2018 · 88bd151 · 88bd151
1 parent 322e79b
commit 88bd151
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/clay-dropdown/src/ClayDropdownBase.soy b/packages/clay-dropdown/src/ClayDropdownBase.soy
@@ -108,6 +108,7 @@
 			{param maxItems: $item.maxItems /}
 			{param separator: $item.separator /}
 			{param spritemap: $spritemap /}
+			{param title: $item.title /}
 		{/delcall}
 	{/for}
 {/template}
@@ -339,6 +340,7 @@
 	{@param? maxItems: int}
 	{@param? separator: bool}
 	{@param? spritemap: string}
+	{@param? title: string}
 
 	{let $itemContent kind="html"}
 		{call ClayLink.render}
@@ -383,6 +385,8 @@
 					{$iconContent}
 				{/if}
 			{/param}
+
+			{param title: $title /}
 		{/call}
 	{/let}
 
@@ -417,6 +421,7 @@
 	{@param? maxItems: int}
 	{@param? separator: bool}
 	{@param? spritemap: string}
+	{@param? title: string}
 
 	{let $checkbox kind="html"}
 		{call ClayCheckbox.render}
@@ -466,6 +471,7 @@
 	{@param? maxItems: int}
 	{@param? separator: bool}
 	{@param? spritemap: string}
+	{@param? title: string}
 
 	{if $label and $label != ''}
 		<li class="dropdown-subheader" role="presentation">
@@ -506,6 +512,7 @@
 	{@param? maxItems: int}
 	{@param? separator: bool}
 	{@param? spritemap: string}
+	{@param? title: string}
 
 	{let $radio kind="html"}
 		{call ClayRadio.render}
@@ -556,6 +563,7 @@
 	{@param? maxItems: int}
 	{@param? separator: bool}
 	{@param? spritemap: string}
+	{@param? title: string}
 
 	{if $label and $label != ''}
 		<li class="dropdown-subheader" role="presentation">

diff --git a/packages/clay-dropdown/src/items_validator.js b/packages/clay-dropdown/src/items_validator.js
@@ -11,6 +11,7 @@ let itemShape = {
 	label: Config.oneOfType([Config.number(), Config.string()]),
 	maxItems: Config.number(),
 	separator: Config.bool().value(false),
+	title: Config.string(),
 	type: Config.oneOf(['checkbox', 'group', 'item', 'radiogroup']).value(
 		'item'
 	),

diff --git a/packages/clay-management-toolbar/src/validators.js b/packages/clay-management-toolbar/src/validators.js
@@ -8,6 +8,7 @@ let actionItemShape = {
 	label: Config.string().required(),
 	quickAction: Config.bool(),
 	separator: Config.bool().value(false),
+	title: Config.string(),
 	type: Config.oneOf(['group', 'item']).value('item'),
 };
 
@@ -21,6 +22,7 @@ let creationMenuItem = {
 	icon: Config.string(),
 	label: Config.string().required(),
 	separator: Config.bool().value(false),
+	title: Config.string(),
 };
 
 const creationMenuItemsValidator = Config.arrayOf(
@@ -38,6 +40,7 @@ let filterItemShape = {
 	inputValue: Config.string(),
 	label: Config.string().required(),
 	separator: Config.bool().value(false),
+	title: Config.string(),
 	type: Config.oneOf(['checkbox', 'group', 'item', 'radiogroup']),
 };