Skip to content

Commit

Permalink
Add note about submitting PRs on master
Browse files Browse the repository at this point in the history
Summary:
We got a lot of PRs on stable branches recently, this adds a note about that in CONTRIBUTING that (hopefully) people will read.
Closes facebook#8209

Differential Revision: D3454813

fbshipit-source-id: 4f972d9e5edc1f13b249d9f7a627f84ba9826a0a
  • Loading branch information
janicduplessis authored and Facebook Github Bot 1 committed Jun 18, 2016
1 parent d929f1c commit e08197b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ We will do our best to keep `master` in good shape, with tests passing at all ti

The core team will be monitoring for pull requests. When we get one, we'll run some Facebook-specific integration tests on it first. From here, we'll need to get another person to sign off on the changes and then merge the pull request. For API changes we may need to fix internal uses, which could cause some delay. We'll do our best to provide updates and feedback throughout the process.

Please submit your pull request on the *master* branch. If the fix is critical and should be included in a stable branch please mention it and it will be cherry picked into it.

*Before* submitting a pull request, please make sure the following is done…

1. Fork the repo and create your branch from `master`.
Expand Down

0 comments on commit e08197b

Please sign in to comment.