Remove preprocess and add scaling to FAQ #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove option for
preprocess_bijection
as it could potentially cause confusion. For example, a user may expect to be able to runtrain_flow
twice in order to train for more epochs (e.g. rerunning a cell containingtrain_flow
). However this would not be the case when using apreprocess_bijection
, as the flow outputted from the first call totrain_flow
would already be transformed byInvert(preprocess_bijection)
, and the output from the second call would have the inverse transformation applied twice.Instead, an example is added to the FAQ for scaling/preprocessing, which is more explicit.