Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root finding #195

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Root finding #195

merged 3 commits into from
Dec 3, 2024

Conversation

danielward27
Copy link
Owner

@danielward27 danielward27 commented Dec 3, 2024

Tidies up root finding.

We now use composition with NumericalInverse to provide a root finding method for a bijection e.g. without an analytical inverse.

This is a breaking change, specifically:

  • Users explicitly calling the root finding algorithms will have to change to the new module name and functions
    (flowjax.bisection_search -> flowjax.root_finding). See the updated function names and documentation in the module.
  • Users searching through the attributes of block_neural_autoregressive_flows may face a breaking change, due to the additional "layer" of composition, from NumericalInverse (another .bijection will need to be added to get to extract the BlockAutoregressiveNetwork).
  • Users directly calling inverse methods on BlockAutoregressiveNetwork will now get an error, suggesting to provide an inverse method with NumericalInverse. Note, a method is provided within block_neural_autoregressive_flow.

@danielward27 danielward27 merged commit d0b3139 into main Dec 3, 2024
1 check passed
@danielward27 danielward27 deleted the root_finding branch December 3, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant