Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidies up root finding.
We now use composition with
NumericalInverse
to provide a root finding method for a bijection e.g. without an analytical inverse.This is a breaking change, specifically:
(
flowjax.bisection_search
->flowjax.root_finding
). See the updated function names and documentation in the module.block_neural_autoregressive_flows
may face a breaking change, due to the additional "layer" of composition, fromNumericalInverse
(another.bijection
will need to be added to get to extract theBlockAutoregressiveNetwork
).BlockAutoregressiveNetwork
will now get an error, suggesting to provide an inverse method withNumericalInverse
. Note, a method is provided withinblock_neural_autoregressive_flow
.