Skip to content

Commit

Permalink
feat(package): update to angular12
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Users will need to upgrade to 12.0.0 of Angular/Angular CLI in order to use this.
In order to migrate, please see https://update.angular.io
Close ionic-team#447. Closes ionic-team#448
  • Loading branch information
rdlabo authored and mhartington committed May 25, 2021
1 parent 0e78676 commit 707175d
Show file tree
Hide file tree
Showing 6 changed files with 10,162 additions and 39,068 deletions.
69 changes: 34 additions & 35 deletions builders/cordova-serve/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,44 +85,43 @@ function getTransforms(
const cordovaServeTransform: (
formattedAssets: FormattedAssets,
context: BuilderContext,
) => ExecutionTransformer<Configuration> = (
formattedAssets,
{ workspaceRoot },
) => browserWebpackConfig => {
const scriptExtras = formattedAssets.globalScriptsByBundleName.map(
(script: { bundleName: any; paths: any }) => {
const bundleName = script.bundleName;
return new ScriptsWebpackPlugin({
name: bundleName,
sourceMap: true,
filename: `${basename(bundleName)}.js`,
scripts: script.paths,
basePath: workspaceRoot,
});
},
);
) => ExecutionTransformer<Configuration> =
(formattedAssets, { workspaceRoot }) =>
browserWebpackConfig => {
const scriptExtras = formattedAssets.globalScriptsByBundleName.map(
(script: { bundleName: any; paths: any }) => {
const bundleName = script.bundleName;
return new ScriptsWebpackPlugin({
name: bundleName,
sourceMap: true,
filename: `${basename(bundleName)}.js`,
scripts: script.paths,
basePath: workspaceRoot,
});
},
);

const copyWebpackPluginInstance = new CopyWebpackPlugin({
patterns: formattedAssets.copyWebpackPluginPatterns,
});
const copyWebpackPluginInstance = new CopyWebpackPlugin({
patterns: formattedAssets.copyWebpackPluginPatterns,
});

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
browserWebpackConfig.plugins!.push(
...scriptExtras,
copyWebpackPluginInstance,
);
return browserWebpackConfig;
};
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
browserWebpackConfig.plugins!.push(
...scriptExtras,
copyWebpackPluginInstance,
);
return browserWebpackConfig;
};

export const indexHtmlTransformFactory: (
formattedAssets: FormattedAssets,
context: BuilderContext,
) => IndexHtmlTransform = ({ globalScriptsByBundleName }) => (
indexTransform: string,
) => {
const augmentedHtml = augmentIndexHtml(
indexTransform,
globalScriptsByBundleName,
);
return Promise.resolve(augmentedHtml);
};
) => IndexHtmlTransform =
({ globalScriptsByBundleName }) =>
(indexTransform: string) => {
const augmentedHtml = augmentIndexHtml(
indexTransform,
globalScriptsByBundleName,
);
return Promise.resolve(augmentedHtml);
};
Loading

0 comments on commit 707175d

Please sign in to comment.