Fixed conditional rendering for Helper component

danielshin · Mar 30, 2017 · 7ee3786 · 7ee3786
1 parent d637baa
commit 7ee3786
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/components/field/index.js b/src/components/field/index.js
@@ -291,8 +291,8 @@ export default class TextField extends Component {
 
         <Animated.View style={helperContainerStyle}>
           <View style={styles.flex}>
-            {error && <Helper style={errorStyle} text={error} />}
-            {title && <Helper style={titleStyle} text={title} />}
+            <Helper style={errorStyle} text={error} />
+            <Helper style={titleStyle} text={title} />
           </View>
 
           <Counter {...{ baseColor, errorColor, count, limit }} />

diff --git a/src/components/helper/index.js b/src/components/helper/index.js
@@ -9,16 +9,16 @@ export default class Helper extends Component {
   };
 
   static propTypes = {
-    text: PropTypes.string.isRequired,
+    text: PropTypes.string,
   };
 
   render() {
     let { text, ...props } = this.props;
 
-    return (
+    return text? (
       <View style={styles.container}>
         <Animated.Text {...props}>{text}</Animated.Text>
       </View>
-    );
+    ) : null;
   }
 }