Skip to content

getting LogToDB instance in SaveNewLogEvent #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

ArtemKahramanov
Copy link
Contributor

No description provided.

@danielme85
Copy link
Owner

Hi, thank your contribution. Looks like you also need to update the expected types:

Argument #1 ($record) must be of type Monolog\LogRecord, danielme85\LaravelLogToDB\LogToDB given, called in /home/runner/work/laravel-log-to-db/laravel-log-to-db/src/LogToDB.php on line 172

Sorry the testing/action/runners on this repo don't run automatically for "new" github users. I changed the settings so it should be less strict now,. so you can try again if you want ;)

Copy link
Owner

@danielme85 danielme85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@danielme85 danielme85 merged commit c9da498 into danielme85:main Mar 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants