Add more printer attributes, fix length of StringWithLanguage, enhance IppProtocol class#27
Merged
danielklecha merged 6 commits intodanielklecha:masterfrom Feb 18, 2026
Merged
Conversation
pkocsis-kfx
commented
Feb 18, 2026
pkocsis-kfx
commented
- Added PrinterUUID to PrinterDescriptionAttributes
- Added defines for more printer attributes (compression-default, media-col-supported, media-col-ready, printer-uuid, pdf-versions-supported, ipp-features-supported, media-type-supported)
- Fixed calculation of length of type StringWithLanguage
- Fixed test case of Write_StringWithLanguage_ShouldBeWritten to match the fixed behavior
- Added new property 'ReadDocumentStream' to IppProtocol class, to be able to control if the library should read the incoming document into the memory or not.
Added defines for more printer attributes (compression-default, media-col-supported, media-col-ready, printer-uuid, pdf-versions-supported, ipp-features-supported, media-type-supported)
…ble to control if the library should read the incoming document into the memory or not.
…ull stream instead of a newly created (but later unused) MemoryStream instance.
Owner
|
@pkocsis-kfx thanks for improvements! Currently I'm working with tests and code coverage. I have a plan to publish version 3.0.0 in this month. Btw. If you need to add custom attribtes then check ImproveGetPrinterAttributesRawResponse in SharpIppNextServer. I put there attributes which are required by printer wizard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.