Support lifetime elision. #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7 This is achieved by having the (proc-)macro replace elided lifetimes with auto-generated explicitly-named equivalent signatures, before applying the rest of the `with_locals` magic. TODO: - Add UI tests to make sure the error messages are nice; - Add a functionality to hack `deny(elided_lifetimes_in_paths)` to make sure the macro does not misbehave (since it can't, otherwise, know there are elided lifetime parameters there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
This is achieved by having the (proc-)macro replace
elided lifetimes with auto-generated explicitly-named
equivalent signatures, before applying the rest of the
with_localsmagic.TODO:
Add UI tests to make sure the error messages are nice;
Add a functionality to hack
deny(elided_lifetimes_in_paths)to make sure the macro does not misbehave (since it can't,
otherwise, know there are elided lifetime parameters there).