Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide secret input during API config, fixes #232 #233

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

danielgtaylor
Copy link
Owner

This replaces the input for passwords/secrets with * using the existing survey library. It looks like it was recently archived, so we'll need to replace it at some point.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #233 (1ecdb09) into main (2db8c10) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   76.90%   76.84%   -0.07%     
==========================================
  Files          26       26              
  Lines        3663     3666       +3     
==========================================
  Hits         2817     2817              
- Misses        639      642       +3     
  Partials      207      207              
Files Coverage Δ
cli/interactive.go 47.25% <0.00%> (-0.61%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db8c10...1ecdb09. Read the comment docs.

@danielgtaylor danielgtaylor merged commit 21a9017 into main Dec 14, 2023
4 of 6 checks passed
@danielgtaylor danielgtaylor deleted the hide-secrets-input branch December 14, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant