Map enum int's into Enums redux #293
Conversation
Co-authored-by: ydylla <ydylla@gmail.com>
Gobot1234
changed the title
|
This should be ready to go now |
|
+1 to this, for the sake of resolving issue #157 |
# Conflicts: # poetry.lock
|
Not really sure why the install's failing other than it might just be time to drop 3.6? |
|
Actually this is probably just cause poetry dropped 3.6 support |
|
@danielgtaylor @kalzoo will this ever be merged or implemented from maintainers? Current implementation makes no sense. Message enum field should have an appropriate type and not just int. |
|
Python 3.6 is already at its end of life anyways, and soon 3.7 will be too, so I don't think support for 3.6 should matter that much. And people using this project, instead of Google's official Python implementation, are likely here because they want newer features, so I don't think most would care for 3.6 anyways. |
|
Is there any reason this PR is not merged? |
|
If it means anything to a (hopefully) future reviewer, I've been using it in prod for a couple months and it's been working flawlessly. |
|
Just saw this in my review queue, reading now |
Re-implement Enum to be faster along with being an open set --------- Co-authored-by: ydylla <ydylla@gmail.com>
Re-implement Enum to be faster along with being an open set --------- Co-authored-by: ydylla <ydylla@gmail.com>
|
Do these enums support identity comparison (
|
|
Yes they should |
A continuation of #273 containing a reimplementation of betterproto.Enum (with 3.11+ features) as an open set along with some tests for this.
Closes #291
Closes #157
Closes #169