Skip to content

Fix compilation of fields named 'bytes' #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix compilation of fields named 'bytes' #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0c9a5
more keyword filtering
SpencerSharkey Dec 31, 2020
d321df2
style
SpencerSharkey Jan 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/betterproto/casing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ def lowercase_first(value: str) -> str:
return value[0:1].lower() + value[1:]


def is_keyword(value: str) -> bool:
if keyword.iskeyword(value):
return True

if value == "bytes":
return True

return False


def sanitize_name(value: str) -> str:
# https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
return f"{value}_" if keyword.iskeyword(value) else value
return f"{value}_" if is_keyword(value) else value