Skip to content

Deprecated field not taken into account on methods #595

Closed
@AdrienVannson

Description

@AdrienVannson

Summary

No warning is shown when using methods declared with option deprecated = true;

Reproduction Steps

Compile the following .proto file:

syntax = "proto3";
package issue;

message Msg {}

service MyService {
    rpc deprecated_func(Msg) returns (Msg) { option deprecated = true; };
}

Expected Results

I would expect deprecated_func from MyServiceStub to generate a DeprecatedWarning when called, as it is the case when using deprecated fields or messages.

Actual Results

No warning is shown.

System Information

libprotoc 3.12.4
Python 3.10.12
Name: betterproto
Version: 2.0.0b6
Summary: A better Protobuf / gRPC generator & library
Home-page: https://github.com/danielgtaylor/python-betterproto
Author: Daniel G. Taylor
Author-email: danielgtaylor@gmail.com
License: MIT
Location: XXX/python-betterproto/.venv/lib/python3.10/site-packages
Editable project location: XXX/python-betterproto
Requires: grpclib, python-dateutil, typing-extensions
Required-by:

Checklist

  • I have searched the issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have verified this issue occurs on the latest prelease of betterproto which can be installed using pip install -U --pre betterproto, if possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions