feat: ability to fetch router from huma context #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to query the router for information. I've added a GetOperation method so we can query for information about a given operation. This is useful in hypermedia APIs because it allows us to link across different endpoints without having to hardwire paths. Instead, the cross-referencing is done via operation id.
| @@ -34,6 +37,15 @@ func GetConn(ctx context.Context) net.Conn { | |||
| return nil | |||
| } | |||
|
|
|||
| // GetRouter gets the `*Router` handling API requests | |||
| func GetRouter(ctx context.Context) *Router { | |||
There was a problem hiding this comment.
Can this be used to greatly simplify the code in #80? The context would already have the router injected and there's no need to pass it around everywhere right? 🤔
There was a problem hiding this comment.
Possibly. Note that several tests don't have a router (in which case I send in nil). But since the GetRouter function returns nil when it can't find a Router in the context, then it should actually be pretty equivalent. I agree, it would simplify the code. The issue here was that I wanted to provide you with independent PRs in case you decided to reject any. So that's why I don't leverage this in #80. But if you want me to refactor it once this PR is merged, I can certainly do that.
Co-authored-by: Daniel G. Taylor <danielgtaylor@gmail.com>
mt35-rs
added a commit
to mt35-rs/huma
that referenced
this pull request
Dec 6, 2022
danielgtaylor
pushed a commit
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to query the router for information. I've added a GetOperation method so we can query for information about a given operation. This is useful in hypermedia APIs because it allows us to link across different endpoints without having to hardwire paths. Instead, the cross-referencing is done via operation id.