-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using pointers for non param fields in input structs #565
Conversation
…r/cookie parameters
WalkthroughThe changes involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 22 22
Lines 3883 3883
=======================================
Hits 3602 3602
Misses 236 236
Partials 45 45 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- huma.go (2 hunks)
- huma_test.go (1 hunks)
Additional comments not posted (3)
huma_test.go (3)
2062-2064
: LGTM!The declaration of the new type
ResolverWithPointer
is correct.
2066-2070
: LGTM!The
Resolve
method of theResolverWithPointer
type is correctly implemented.
2072-2092
: LGTM!The
TestResolverWithPointer
test function is comprehensive and correctly validates the new functionality.
This PR allows using pointers fields in input structs, if they are not path/query/header/cookie parameters. This gives more flexibility to huma users, e.g. when defining resolvers
Summary by CodeRabbit
New Features
Bug Fixes