Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update transforms.go to use explicit Host function from huma.Context #139

Merged

Conversation

james-andrewsmith
Copy link
Contributor

Hey @danielgtaylor 👋🏼

Firstly - just found Huma and loving it - very quickly I've been able to get a TRPC-like workflow running which is amazing.

It looks like Chi does not provide the Host header through the Header func but it is explicitly available via the Host func. This meant the $schema never had a hostname and would return https:///schema....

Chi does not provide the Host header through the Header func but it is explicitly available via the Host func.
Copy link
Owner

@danielgtaylor danielgtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on my short list of things to fix ASAP but you beat me to it, thank you! 🚀

@danielgtaylor danielgtaylor merged commit 4b63538 into danielgtaylor:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants