WorkflowOptions support for configuring max number of concurrent tasks. #287
Conversation
|
Hello, |
| @@ -67,6 +70,16 @@ public void UseErrorRetryInterval(TimeSpan interval) | |||
| { | |||
| ErrorRetryInterval = interval; | |||
| } | |||
|
|
|||
| public void UseMaxConcurrentItems(int? maxConcurrentItems) | |||
There was a problem hiding this comment.
Perhaps we should make this explicitly the max number of concurrent workflows rather than items?
There was a problem hiding this comment.
Let me make that change you've suggested. Most consumers of your API may not ever dig into the internals, and thus not know what maxConcurrentItems really means, but framing it as "max number of concurrent workflows" is more intuitive.
There was a problem hiding this comment.
I think instead of modifying EventConsumer directly, I'll move the change to WorkflowConsumer...that way the other child consumers can keep their default behavior the way you intended.
| @@ -13,7 +13,7 @@ internal class EventConsumer : QueueConsumer, IBackgroundTask | |||
| private readonly IPersistenceProvider _persistenceStore; | |||
| private readonly IDistributedLockProvider _lockProvider; | |||
| private readonly IDateTimeProvider _datetimeProvider; | |||
| protected override int MaxConcurrentItems => 2; | |||
| protected override int MaxConcurrentItems => WorkflowOptions.MinimumNumberOfConcurrentItems; | |||
There was a problem hiding this comment.
This doesn't make sense to me... is this a typo?
There was a problem hiding this comment.
That was intentional, because MaxConcurrentItems as a function of the number 2 was showing in two places, the EventConsumer and QueueConsumer. And then I added a 3rd place it where it shows up in the WorkflowOptions class. I was concerned the number 2 was becoming a magic number duplicated in too many locations, and so an explicitly named constant helps to maintain the context of what the value 2 is for. This change doesn't add a ton of value, so I can revert it if its problematic.
…cific to WorkflowConsumer only.
No description provided.