add support to get multiple workflow instances by a list of ids #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgerlag
requested changes
Mar 9, 2019
There was a problem hiding this comment.
Could you add some testing WorkflowCore.UnitTests.BasePersistenceFixture?
There are test projects for every persistence implementation that inherit from this and they use docker containers to spin up the underlying database to execute the tests against...
You should be able to use that to verify them all.
src/WorkflowCore/Services/DefaultProviders/MemoryPersistenceProvider.cs
Outdated
Show resolved
Hide resolved
src/providers/WorkflowCore.Persistence.MongoDB/Services/MongoPersistenceProvider.cs
Outdated
Show resolved
Hide resolved
|
I extended the testing in |
|
Tests against DynamoDb are failing |
|
After dealing a long time to connect to the DynamoDB container, I fixed now the DynamoDB provider |
germandb
reviewed
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to get multiple workflow instances by a list of ids ( issue #261 )