Skip to content

Added event OnDataChanged for code reduce in same cases #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added event OnDataChanged for code reduce in same cases #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d99ad7
Added event OnDataChanged for code reduce in same cases
VasiliyLu Apr 13, 2017
3ad0388
Added AfterInsert hook
May 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ColumbusCommons.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ TCustomColumbusModule = class(TColumbusSubject)
procedure BeforeDelete(aDataSet: TDataSet); overload;
procedure BeforeEdit(aDataSet: TDataSet); overload;
procedure BeforeInsert(aDataSet: TDataSet); overload;
procedure AfterInsert(aDataSet: TDataSet); overload;
procedure AfterOpen(aDataSet: TDataSet); overload;
procedure AfterPost(aDataSet: TDataSet); overload;
procedure AfterDelete(aDataSet: TDataSet); overload;
Expand All @@ -77,11 +78,13 @@ TCustomColumbusModule = class(TColumbusSubject)
procedure BeforeDelete; overload; virtual;
procedure BeforeEdit; overload; virtual;
procedure BeforeInsert; overload; virtual;
procedure AfterInsert; overload; virtual;
procedure AfterOpen; overload; virtual;
procedure AfterPost; overload; virtual;
procedure AfterDelete; overload; virtual;
procedure AfterScroll; overload; virtual;
procedure AfterRefresh; overload; virtual;
procedure AfterDataChanged; virtual;
procedure OnCalcFields; overload; virtual;
procedure OnEditError(E: EDatabaseError; var Action: TDataAction); overload; virtual;
property DataSetOwner: TComponent read FDataSetOwner;
Expand Down Expand Up @@ -122,16 +125,19 @@ implementation
procedure TCustomColumbusModule.AfterDelete(aDataSet: TDataSet);
begin
AfterDelete;
AfterDataChanged;
end;

procedure TCustomColumbusModule.AfterOpen(aDataSet: TDataSet);
begin
AfterOpen;
AfterDataChanged;
end;

procedure TCustomColumbusModule.AfterPost(aDataSet: TDataSet);
begin
AfterPost;
AfterDataChanged;
end;

procedure TCustomColumbusModule.AfterScroll(aDataSet: TDataSet);
Expand All @@ -142,6 +148,7 @@ procedure TCustomColumbusModule.AfterScroll(aDataSet: TDataSet);
procedure TCustomColumbusModule.AfterRefresh(aDataSet: TDataSet);
begin
AfterRefresh;
AfterDataChanged;
end;

procedure TCustomColumbusModule.BeforeDelete(aDataSet: TDataSet);
Expand Down Expand Up @@ -231,6 +238,9 @@ procedure TCustomColumbusModule.HookEvents(aDataSet: TDataSet);
Assert(not Assigned(aDataSet.BeforeInsert), 'BeforeInsert is set on ' + aDataSet.name);
aDataSet.BeforeInsert := BeforeInsert;

Assert(not Assigned(aDataSet.AfterInsert), 'AfterInsert is set on ' + aDataSet.name);
aDataSet.AfterInsert := AfterInsert;

Assert(not Assigned(aDataSet.AfterOpen), 'AfterOpen is set on ' + aDataSet.name);
aDataSet.AfterOpen := AfterOpen;

Expand Down Expand Up @@ -380,11 +390,26 @@ procedure TColumbusSubject.UnRegisterService(aService: IColumbusService);

{$REGION 'Virtual Methods'}

procedure TCustomColumbusModule.AfterDataChanged;
begin
// do nothing
end;

procedure TCustomColumbusModule.AfterDelete;
begin
// do nothing
end;

procedure TCustomColumbusModule.AfterInsert(aDataSet: TDataSet);
begin
AfterInsert;
end;

procedure TCustomColumbusModule.AfterInsert;
begin
// do nothing
end;

procedure TCustomColumbusModule.AfterOpen;
begin
// do nothing
Expand Down