Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info on cross-referencing to the docs #142

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Owner

@danieleades danieleades commented Apr 15, 2024

add support and documentation for creating cross references to vertices

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6548b9d) to head (8420d37).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          508       508           
=========================================
  Hits           508       508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danieleades
Copy link
Owner Author

@picnixz i was hoping to ask you another favour here.

cross-referencing as described in this PR doesn't actually work. Can you provide any advice on what it would take to make this work correctly?

i'm agnostic to the syntax at this stage. I have considered-

  • :ref:'node-001'
  • :ref:'vertex:node-001'
  • :vertex:'node-001'

@danieleades
Copy link
Owner Author

@picnixz i did some more digging into this, and i'm a little confused.

  • the custom directives create a target_node in the document when they are first processed
  • given the reference target exists why can't i reference it using a standard :ref: directive?
  • i've tried explicitly registering the target node with document.note_explicit_target but this doesn't make any difference. What is this for?

my fallback option is to create a custom vertexref role and manually resolve the references, but it seems strange I can't leverage the existing reference mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant